Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include invalid sitemaps in trees #39

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Don't include invalid sitemaps in trees #39

wants to merge 2 commits into from

Conversation

gbenson
Copy link

@gbenson gbenson commented May 17, 2023

This PR fixes two issues:

  • Running sitemap_tree_for_homepage on sites with no /robots.txt returns trees containing InvalidSitemap objects.
  • A test failed when run with newer versions of urllib3.

antonialoytorrens-ikaue added a commit to antonialoytorrens-ikaue/ultimate-sitemap-parser that referenced this pull request Jan 9, 2024
@antonialoytorrens-ikaue
Applied mediacloud#39
f5389a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gbenson