Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9122): detect unsafe redirection on login #9131

Merged
merged 2 commits into from
May 20, 2024

Conversation

garethbowen
Copy link
Member

@garethbowen garethbowen commented May 19, 2024

Description

#9122

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@garethbowen garethbowen requested a review from sugat009 May 20, 2024 08:03
@garethbowen
Copy link
Member Author

@sugat009 Would you mind reviewing this? Check out the issue for details on what it's trying to protect against.

It's more complicated than I'd like. The "proper" solution is not to take a URL as parameter but rather take enough context to go to redirect to the right place. Alternatively instead of having the redirect in the http response we could just load the app and pass the path to angular to sort out. But it's fiddly to do this and may break backwards compatibility so this is the safer option for now.

@garethbowen garethbowen merged commit b565e13 into master May 20, 2024
39 checks passed
@garethbowen garethbowen deleted the 9122-detect-double-slash-redirection branch May 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants