Update electron to 4.0.8 #1337
Merged
Update electron to 4.0.8 #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update required in order to fix performance degradation due to memory leak issue electron/electron#16772.
|
Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/meetfranz/franz/issues/1317
Update required in order to fix performance degradation due to memory leak issue electron/electron#16772.
Description
Bumps version of electron in
package.jsonfrom 4.0.4 to 4.0.8Motivation and Context
Due to a memory leak issue found in version 4.0.4 of electron, host machine resource utilization was going through the roof.
How Has This Been Tested?
Ran the local environment with 4.0.4 and then with 4.0.8 and checked CPU temperature sensors.
Screenshots (if appropriate):
Types of changes
Checklist:
$ yarn lint).