Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable self referential rtxn #261

Merged
merged 1 commit into from May 16, 2024
Merged

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented May 6, 2024

Enables rtxn that owns their env with static lifetimes.

That can be practical when your env is stored in the same struct that holds the Database and you don't want to create a self-referential struct

@irevoire irevoire requested a review from Kerollmops May 6, 2024 16:52
@irevoire irevoire force-pushed the enable-self-referential-rtxn branch from a3339c8 to 28b1cfe Compare May 6, 2024 16:54
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like this PR. Thank you very much ❤️

@Kerollmops Kerollmops added this to the v0.20.1 milestone May 16, 2024
@Kerollmops Kerollmops added the enhancement New feature or request label May 16, 2024
@Kerollmops Kerollmops merged commit 73e577e into main May 16, 2024
8 checks passed
@Kerollmops Kerollmops deleted the enable-self-referential-rtxn branch May 16, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants