Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temp fix for failing node v10 #755

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Temp fix for failing node v10 #755

merged 2 commits into from
Jan 20, 2021

Conversation

bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jan 19, 2021 •
edited

This fixes the failing tests until this has changed jsdom/jsdom#2961

Tests were failing because of the latest version of JSdom that introduced this bug: jsdom/jsdom#2961. We only have the bug now as we have updated jest to its latest version.

Multiple solutions are considerable:

  • Adding a resolution to a previous version of jsdom which works with yarn but not npm
  • Add a polyfill for globalThis
  • Remove node 10 from test until resolved: loilo/livy@83de8b1
  • Change the JsDom version used by explicitly telling so in jest config (which is kinda what create-react-app (85k stars) did but without using an external library)

I went for the last option.

Another thing to consider is that Node 10 is almost EOL (end of life)

We might consider dropping support in the futur
Screenshot 2021-01-19 at 16 57 25

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Jan 20, 2021
curquiza
curquiza approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 20, 2021

Build succeeded:

@bors bors bot merged commit 8e4323d into master Jan 20, 2021
@bors bors bot deleted the temp_fix_for_jsdom branch January 20, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bidoubiwa @curquiza