Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to listen on unix domain sockets #4528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kristofvandam
Copy link

@kristofvandam kristofvandam commented Mar 22, 2024

Pull Request

What does this PR do?

  • adds the ability to set a Unix domein socket as host_addr
  • show the protocol used on startup

reason

It's easier to create multiple instances and create (nginx for example) vhosts for them

PR checklist

Please check if your PR fulfills the following requirements:

  • [ x ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [ x ] Have you read the contributing guidelines?
  • [ x ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kristofvandam 👋 Thank you very much for your contribution. Have you tested these changes, already?

@kristofvandam
Copy link
Author

Hi, not yet, i don't have any Windows environment in my reach 🫤 i'm not familiar with rust either, i just thought it was an easy fix and gave it a go tbh 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants