Fix failure handling in spec retry #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents new number suffixes being allocated for given snapshots in the event of a rety.
kpdecker
changed the title
window:before:unload reset would break tests that have explicit reloads in them
|
Nice trick ! I did think about resetting after test completion ! |
|
@edimitchel what about merging this pr? |
|
I cannot, build is not passing and I cannot change anything on project for be able to do... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in retry mode with a failing snapshot, we would see the expected failure on the first attempt. On the second attempt this would pass as the numeric ID for the snapshot was incremented, creating a new snapshot.
This PR changes behavior so that