[WC-2383] Force close rollup process hanging #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leonardomendix Could you please bump the pwt package.json and lock file version to And also write release notes in the changelog? |
Done! ✅ |
jeffersonRibeiro
approved these changes
Mar 6, 2024
legio-vi-ferrata
approved these changes
Mar 6, 2024
leonardomendix
force-pushed
the
fix/rollup-hanging-sometimes
branch
from
1835345
to
d4cfd36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅This PR contains
What is the purpose of this PR?
Sometimes when running the pluggable widget tools script for release or build a widget, the rollup doesn’t finish the process. That happens in the editorConfig step.
Relevant changes
To resolve that for now I have followed one suggestion from the rollup repository PR to force close the process because we’re still using rollup v3 in the pluggable widget tools.
That was fixed in v4, it was created one new parameter to pass to rollup to force exit. If so, then this fix can be removed and starts to use the new parameter mentioned above.
rollup/rollup#4213 (comment)