Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all listeners on close #1031

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

aldotms70
Copy link
Contributor

This patch calls the removeListener on emitter for all subscribed topics. It is important to avoid memory leak.
When using MQEmitterRedis is most important to unsubscribe pattern on redis server.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3c40d45 into mercurius-js:master Oct 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants