Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding validation to verify if baseUrl is already present in th… #1052

Conversation

nandorodrigu3s
Copy link
Contributor

@nandorodrigu3s nandorodrigu3s commented Nov 19, 2023

closes #1046

  • adding validation to prevent path duplication when prefix is set.
  • prevent GraphiQL of getting error 404 to request GraphQL API endpoint.

…e GRAPHQL_ENDPOINT variable to prevent GrahphIql's request get error 404 Not Found
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -1,6 +1,6 @@
{
"name": "mercurius",
"version": "13.3.0",
"version": "13.3.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "13.3.1",
"version": "13.3.0",

We'll bump the version accordingly on release

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e58db21 into mercurius-js:master Nov 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphiQL issues in newest release
2 participants