Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/remove federation #942

Merged
merged 6 commits into from
Jan 17, 2023
Merged

Feat/remove federation #942

merged 6 commits into from
Jan 17, 2023

Conversation

marco-ippolito
Copy link
Contributor

resolves: #929
replaces: #916

I've tried to take @codeflyer work to remove gateway now that it has been released as standalone package, and continue working on it

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

docs/hooks.md Outdated Show resolved Hide resolved
docs/hooks.md Outdated Show resolved Hide resolved
docs/hooks.md Outdated Show resolved Hide resolved
docs/lifecycle.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jonnydgreen jonnydgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible stuff - some comments from me!

docs/federation.md Outdated Show resolved Hide resolved
docs/hooks.md Show resolved Hide resolved
@@ -80,7 +80,6 @@ service.register(mercurius, {
}
}
},
federationMetadata: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment relevant for L63: I think the schema on L63 needs changing as I believe it will error now

test/types/index.ts Show resolved Hide resolved
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jonnydgreen jonnydgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Collaborator

I'll ship it soon. @codeflyer can you take a look?

Copy link
Contributor

@codeflyer codeflyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!!

@mcollina mcollina merged commit 4f2fc90 into mercurius-js:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roadmap: migration of mercurius-gateway
4 participants