Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include subscription id in onSubscriptionEnd hook #963

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

RomuloVitoi
Copy link
Contributor

This is related to #959, it will be needed in the gateway to identify when a subscription has ended and which subscription was that.

@RomuloVitoi RomuloVitoi changed the title chore: include subscription id in onSubscriptionEnd hook feat: include subscription id in onSubscriptionEnd hook Feb 15, 2023
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that verifies that the id matches whatever it was passed before?

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 0e8dc55 into mercurius-js:master Feb 17, 2023
@RomuloVitoi RomuloVitoi deleted the onSubscriptionEnd branch February 17, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants