fix mutation over websocket/subscription #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Apr 26, 2023
index.js
Outdated
| @@ -471,7 +471,7 @@ const plugin = fp(async function (app, opts) { | |||
| document = cached.document | |||
| } | |||
|
|
|||
| if (reply && reply.request.raw.method === 'GET') { | |||
| if (reply && reply.request.raw.method === 'GET' && reply.request.headers.upgrade?.toLowerCase() !== 'websocket') { | |||
There was a problem hiding this comment.
Suggested change
| if (reply && reply.request.raw.method === 'GET' && reply.request.headers.upgrade?.toLowerCase() !== 'websocket') { | |
| if (reply && reply.request.raw.method === 'GET' && !reply.request.ws) { |
There was a problem hiding this comment.
This should work, check it out!
There was a problem hiding this comment.
Thanks, it worked with manual testing, so I updated the corresponding test to set that flag on the request like fastify-websocket does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where mutations are not allowed over web sockets (subscriptions).
See: #977