Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to @fastify/websocket v8 #987

Merged
merged 1 commit into from Apr 27, 2023
Merged

Conversation

mcollina
Copy link
Collaborator

Updates to @fastify/websocket v8 to address a leak and crash in certain condition. This requires a minimum version of Fastify of v4.16.0 (just released), hence the major update.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
Copy link
Collaborator Author

cc @simoneb @codeflyer @marco-ippolito @jonnydgreen wdyt?

This fixes a horrible crash in Platformatic, so I'm keen on shipping this sooner rather than later.

@simoneb
Copy link
Collaborator

simoneb commented Apr 26, 2023

I'm afraid I'm missing some context but it looks like this is part of a group of upgrades to various packages that need to go together (I see the major in fastify-ws, a minor followed by various patches in fastify, fastify-json-stringify and compiler, ...). There's an overarching plan I'm missing, but I guess we're good as I wouldn't be in any better position than you are to validate this change.

@mcollina
Copy link
Collaborator Author

There is no grand plan, just this bug to be fixed fastify/fastify-websocket#249. That required a new hook in Fastify and and a semver-major change jn fastify-websocket.

The change in fast-json-stringify was 100% unrelated as well as all the problems in v4.16.3.

@mcollina mcollina merged commit 2680c7b into master Apr 27, 2023
21 checks passed
@mcollina mcollina deleted the update-to-fastify-websocket-v8 branch April 27, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants