New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brew #81
Add brew #81
Conversation
@BastianZim : please, mark your PR as draft and let me know, when it can be merged to master. |
@MindaugasLaganeckas It should already be marked as a draft. Would you mind double-checking in case I marked it incorrectly? |
@BastianZim : thank you very much for the update! Just ping me, when the other end is ready! Merry Christmas! 馃巹 |
@MindaugasLaganeckas |
@MindaugasLaganeckas Sort of a late Christmas present from the Homebrew maintainers 馃槃 but the PR has now been merged Homebrew/homebrew-core#67804 (comment) and mermaid-cli is available on brew.
|
@MindaugasLaganeckas Happy new year! Just wanted to quickly check if you already had some time to review my questions, as I could then add a fix, if required. |
Just saw that there are conflicts prohibiting rebase, seems to be because of the reformatting in #88. Should I just open a new PR? |
@MindaugasLaganeckas Just wanted to check if there is anything I should change? |
@MindaugasLaganeckas Are you still there? |
馃搼 Summary
Brief description about the content of your PR.
Adds brew as a download option
Resolves #25
馃搹 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
N.A.
馃搵 Tasks
Make sure you
master
branchThe PR (
Homebrew/homebrew-core#65521new PR: Homebrew/homebrew-core#67804) at brew is not yet merged, as there are some problems with Chromium but I just wanted to create this draft request for awareness and in case there are any ideas here about fixing Chromium. Right now, there is a temporary solution but maybe there is something more permanent that we're overlooking.