Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brew #81

Closed
wants to merge 2 commits into from
Closed

Add brew #81

wants to merge 2 commits into from

Conversation

BastianZim
Copy link
Contributor

@BastianZim BastianZim commented Dec 1, 2020

馃搼 Summary

Brief description about the content of your PR.
Adds brew as a download option
Resolves #25

馃搹 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.
N.A.

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted master branch

The PR (Homebrew/homebrew-core#65521 new PR: Homebrew/homebrew-core#67804) at brew is not yet merged, as there are some problems with Chromium but I just wanted to create this draft request for awareness and in case there are any ideas here about fixing Chromium. Right now, there is a temporary solution but maybe there is something more permanent that we're overlooking.

@MindaugasLaganeckas
Copy link
Member

@BastianZim : please, mark your PR as draft and let me know, when it can be merged to master.
Thanks a lot for your contribution! 馃槃

@BastianZim
Copy link
Contributor Author

@MindaugasLaganeckas It should already be marked as a draft. Would you mind double-checking in case I marked it incorrectly?
Pleasure! Sorry that it's taking so long but there seems to be an issue with the tests that brew doesn't like and I'm not sure how to fix it, unfortunately.

@MindaugasLaganeckas
Copy link
Member

@BastianZim : thank you very much for the update! Just ping me, when the other end is ready! Merry Christmas! 馃巹

@BastianZim
Copy link
Contributor Author

@MindaugasLaganeckas
Of course, will do! Merry Christmas to you too!

@BastianZim
Copy link
Contributor Author

BastianZim commented Dec 30, 2020

@MindaugasLaganeckas Sort of a late Christmas present from the Homebrew maintainers 馃槃 but the PR has now been merged Homebrew/homebrew-core#67804 (comment) and mermaid-cli is available on brew.
Just two comments:

  1. The README.md switches between ## and ### for the headlines and I couldn鈥檛 find the logic behind it. Should the brew install section be two or three #?
  2. I subscribed to new mermaid-cli releases, as the brew version needs to be manually updated each time, so that I don鈥檛 miss them but in case I do or if there are any issues regarding brew, feel free to ping me or just assign the issue to me (Not sure if that鈥檚 possible though?).

@BastianZim
Copy link
Contributor Author

@MindaugasLaganeckas Happy new year! Just wanted to quickly check if you already had some time to review my questions, as I could then add a fix, if required.

@BastianZim BastianZim marked this pull request as ready for review January 12, 2021 19:53
@BastianZim
Copy link
Contributor Author

Just saw that there are conflicts prohibiting rebase, seems to be because of the reformatting in #88. Should I just open a new PR?

@BastianZim
Copy link
Contributor Author

@MindaugasLaganeckas Just wanted to check if there is anything I should change?

@BastianZim
Copy link
Contributor Author

@MindaugasLaganeckas Are you still there?

@BastianZim BastianZim mentioned this pull request Feb 11, 2021
3 tasks
@BastianZim BastianZim closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add brew installation
2 participants