Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add error highlight #1300

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: Add error highlight #1300

wants to merge 1 commit into from

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Sep 15, 2023

📑 Summary

Adds syntax error highlighting with support for directives and yaml frontmatter.

📏 Design Decisions

Adapted from work by @pbrolin47 and @knsv at MermaidChart.
image

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit 4994ecf
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/65040c674adc2c000851517b
😎 Deploy Preview https://deploy-preview-1300--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 15, 2023

1 failed test on run #1120 ↗︎

1 27 6 0 Flakiness 0

Details:

Merge 4994ecf into 2cf66be...
Project: Mermaid Live Editor Commit: 19e8670d5f ℹ️
Status: Failed Duration: 02:38 💡
Started: Sep 15, 2023 7:51 AM Ended: Sep 15, 2023 7:54 AM
Failed  cypress/e2e/loadSite.spec.ts • 1 failed test

View Output Video

Test Artifacts
Verify types of URLs > should load compressed URL Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link

This pr is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant