Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs links in the Editor's Docs button #1335

Merged
merged 10 commits into from
Jan 30, 2024

Conversation

Abrifq
Copy link
Contributor

@Abrifq Abrifq commented Nov 5, 2023

📑 Summary

Brief description about the content of your PR:

Updates the links to redirect correctly on the new documentation site.

Resolves: none. I figured out it would be better to contribute instead of explaining the issue with my broken English.

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

Copy link

netlify bot commented Nov 5, 2023

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit 57eea0f
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/65b8cd248d44be0008d2061e
😎 Deploy Preview https://deploy-preview-1335--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Abrifq
Copy link
Contributor Author

Abrifq commented Nov 5, 2023

There is no unit tests for routes themselves, so I didn't add any.
If needed, it can be done in a separate PR.

@Abrifq Abrifq marked this pull request as ready for review November 5, 2023 19:09
@aloisklink aloisklink self-requested a review November 8, 2023 09:12
@Abrifq
Copy link
Contributor Author

Abrifq commented Nov 9, 2023

@sidharthv96 can you review this PR when you are free?

@Abrifq
Copy link
Contributor Author

Abrifq commented Jan 28, 2024

@sidharthv96 @aloisklink sorry to bump this again but it's annoying to not have this fix merged yet.

Is there anything I forgot to do that prevents the review/merge?

@sidharthv96
Copy link
Member

@Abrifq The root cause of the issue was mermaid-js/mermaid#4989, not the wrong URLs here. I've fixed that with mermaid-js/mermaid#5250.

Also, your PR was a duplicate of an existing one #1329 which added to some confusions.

@sidharthv96
Copy link
Member

Can you add one more change? Currently we're using https://mermaid-js.github.io/mermaid/syntax/flowchart.html, can you change the baseURL to https://mermaid.live so that the URL becomes https://mermaid.live/syntax/flowchart.html?

@Abrifq
Copy link
Contributor Author

Abrifq commented Jan 30, 2024

Can you add one more change? Currently we're using https://mermaid-js.github.io/mermaid/syntax/flowchart.html, can you change the baseURL to https://mermaid.live so that the URL becomes https://mermaid.live/syntax/flowchart.html?

I assume you meant mermaid.js.org since https://mermaid.live/syntax/flowchart.html just 404s

@sidharthv96
Copy link
Member

Yes, my bad. 😅

@sidharthv96 sidharthv96 added this pull request to the merge queue Jan 30, 2024
Merged via the queue into mermaid-js:develop with commit d947dc9 Jan 30, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants