feat: use forest theme in diagram #752
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mermaidjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
sidharthv96
requested changes
Apr 22, 2022
Co-authored-by: Sidharth Vinod <github@sidharth.dev>
|
It does look very nice with the theme, but I'm not able to see the connecting lines... New Old We're losing a lot of info on other diagram types too |
Sure, that sounds good. |
* master:
Bumps [eslint-plugin-mocha](https://github.com/lo1tuma/eslint-plugin-mocha) from 10.0.4 to 10.0.5. - [Release notes](https://github.com/lo1tuma/eslint-plugin-mocha/releases) - [Changelog](https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/CHANGELOG.md) - [Commits](lo1tuma/eslint-plugin-mocha@10.0.4...10.0.5) --- updated-dependencies: - dependency-name: eslint-plugin-mocha dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [postcss-load-config](https://github.com/postcss/postcss-load-config) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/postcss/postcss-load-config/releases) - [Changelog](https://github.com/postcss/postcss-load-config/blob/main/CHANGELOG.md) - [Commits](postcss/postcss-load-config@v4.0.0...v4.0.1) --- updated-dependencies: - dependency-name: postcss-load-config dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [cypress-localstorage-commands](https://github.com/javierbrea/cypress-localstorage-commands) from 1.7.0 to 2.1.0. - [Release notes](https://github.com/javierbrea/cypress-localstorage-commands/releases) - [Changelog](https://github.com/javierbrea/cypress-localstorage-commands/blob/master/CHANGELOG.md) - [Commits](javierbrea/cypress-localstorage-commands@v1.7.0...v2.1.0) --- updated-dependencies: - dependency-name: cypress-localstorage-commands dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [husky](https://github.com/typicode/husky) from 7.0.4 to 8.0.1. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v7.0.4...v8.0.1) --- updated-dependencies: - dependency-name: husky dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…op/husky-8.0.1 chore(deps-dev): bump husky from 7.0.4 to 8.0.1
…op/cypress-localstorage-commands-2.1.0 chore(deps-dev): bump cypress-localstorage-commands from 1.7.0 to 2.1.0
…op/postcss-load-config-4.0.1 chore(deps-dev): bump postcss-load-config from 4.0.0 to 4.0.1
…op/eslint-plugin-mocha-10.0.5 chore(deps-dev): bump eslint-plugin-mocha from 10.0.4 to 10.0.5
…editor into develop * 'develop' of https://github.com/mermaid-js/mermaid-live-editor: Update Browserslist
…editor into develop * 'develop' of https://github.com/mermaid-js/mermaid-live-editor: Update Browserslist
Bumps [@sveltejs/adapter-static](https://github.com/sveltejs/kit/tree/HEAD/packages/adapter-static) from 1.0.0-next.32 to 1.0.0-next.34. - [Release notes](https://github.com/sveltejs/kit/releases) - [Changelog](https://github.com/sveltejs/kit/blob/master/packages/adapter-static/CHANGELOG.md) - [Commits](https://github.com/sveltejs/kit/commits/@sveltejs/adapter-static@1.0.0-next.34/packages/adapter-static) --- updated-dependencies: - dependency-name: "@sveltejs/adapter-static" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 13.0.0 to 13.0.1. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v13.0.0...v13.0.1) --- updated-dependencies: - dependency-name: lint-staged dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint-plugin-tailwindcss](https://github.com/francoismassart/eslint-plugin-tailwindcss) from 3.5.0 to 3.5.2. - [Release notes](https://github.com/francoismassart/eslint-plugin-tailwindcss/releases) - [Commits](francoismassart/eslint-plugin-tailwindcss@v3.5.0...v3.5.2) --- updated-dependencies: - dependency-name: eslint-plugin-tailwindcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps node from 18.2.0 to 18.3.0. --- updated-dependencies: - dependency-name: node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…e-18.3.0 chore(deps): bump node from 18.2.0 to 18.3.0
…op/eslint-plugin-tailwindcss-3.5.2 chore(deps-dev): bump eslint-plugin-tailwindcss from 3.5.0 to 3.5.2
…op/lint-staged-13.0.1 chore(deps-dev): bump lint-staged from 13.0.0 to 13.0.1
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.0.24 to 3.1.1. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/master/CHANGELOG.md) - [Commits](tailwindlabs/tailwindcss@v3.0.24...v3.1.1) --- updated-dependencies: - dependency-name: tailwindcss dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…op/tailwindcss-3.1.1 chore(deps-dev): bump tailwindcss from 3.0.24 to 3.1.1
…nto feature/forestDiagram
|
This pr is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Use the forest theme provided by
mermaidwhen the theme is set toforeston the platform.📏 Design Decisions
Added a bit more logic checking if the theme is forest in
toggleDarkThemein the diagram.📋 Tasks
Make sure you
developbranch