Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #796: Export SVG fix #867

Merged
merged 1 commit into from Jun 28, 2022
Merged

fix #796: Export SVG fix #867

merged 1 commit into from Jun 28, 2022

Conversation

sidharthv96
Copy link
Member

📑 Summary

Brief description about the content of your PR:

Add setAttribute('xmlns:xlink', 'http://www.w3.org/1999/xlink');

Resolves #796

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

This is a temporary fix till the main issue is fixed in mermaid library.
Only few diagrams have this attribute added in mermaid. So SVGs of other diagrams will throw the error.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted master branch

@netlify
Copy link

netlify bot commented Jun 28, 2022

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit dd17fd7
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/62bb4f12580b130008b50fef
😎 Deploy Preview https://deploy-preview-867--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sidharthv96 sidharthv96 self-assigned this Jun 28, 2022
@cypress
Copy link

cypress bot commented Jun 28, 2022



Test summary

25 0 1 0


Run details

Project Mermaid Live Editor
Status Passed
Commit b9961a3 ℹ️
Started Jun 28, 2022 6:59 PM
Ended Jun 28, 2022 7:02 PM
Duration 03:40 💡
OS Linux Ubuntu - 20.04
Browser Electron 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mermaid.live - export svg - svg image error
1 participant