Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs to use mermaid 8.14 #2819

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Updated docs to use mermaid 8.14 #2819

merged 1 commit into from
Mar 17, 2022

Conversation

RonaldZielaznicki
Copy link
Contributor

@RonaldZielaznicki RonaldZielaznicki commented Mar 13, 2022

馃搼 Summary

Updates the docs. 8.13.0 -> 8.14.0

In 8.13.0, a bug #2548 caused ER comments to render incorrectly. The problem was fixed in release 8.13.9.
However, the docs continue to use 8.13.0. So the bug persists (details) in the docs despite the fix.

#2548 can likely be closed after this PR is merged.

馃搹 Design Decisions

The latest version is 8.14. After confirming that 8.14 exists on the cdn, I incremented the version from 8.13.0 -> 8.14.0 so that the docs get the fix that released in 8.13.9, but also so they reflect the latest mermaid has to offer.

馃搵 Tasks

Make sure you

馃摲 Pics

Before:
image

After:
image

@knsv
Copy link
Collaborator

knsv commented Mar 17, 2022

Great! Thanks!

@knsv knsv merged commit 01f571e into mermaid-js:develop Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants