Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add aria-describedby, aria-roledescription #3808

Merged
merged 33 commits into from Dec 8, 2022
Merged

Feat: Add aria-describedby, aria-roledescription #3808

merged 33 commits into from Dec 8, 2022

Commits on Nov 15, 2022

  1. accessibility.js -> ts; + set aria-roledescription; add spec

    @weedySeaDragon
    weedySeaDragon committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    8d96518 View commit details
    Browse the repository at this point in the history

  2. diagrams: use a11y title,desc specific method (was renamed)

    @weedySeaDragon
    weedySeaDragon committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    0d9566d View commit details
    Browse the repository at this point in the history

  3. add "roledescription" to cSpell list of words (as in 'aria-roledescri… 

    …ption')
    @weedySeaDragon
    weedySeaDragon committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    d997076 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Merge remote-tracking branch 'MERMAID/develop' into feat/3626-aria-ro… 

    …ledescription-for-svg
    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    c331305 View commit details
    Browse the repository at this point in the history

  2. (minor) fix typo

    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    03a11e1 View commit details
    Browse the repository at this point in the history

  3. add error checking (empty diagramType, title, desc) to a11y methods

    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    4d7496b View commit details
    Browse the repository at this point in the history

  4. MockedD3: node() return Element; add selectAll()

    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    8a3c4f6 View commit details
    Browse the repository at this point in the history

  5. move mocks specific to only seq spec files out of global d3 mock

    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    1fc0294 View commit details
    Browse the repository at this point in the history

  6. d3 mock: use MockedD3; remove sequence specific mock code

    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    1ad537b View commit details
    Browse the repository at this point in the history

  7. add diagram renderer mocks

    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    f62c5d9 View commit details
    Browse the repository at this point in the history

  8. put a11y into mermaidAPI render; add render spec (mock diagram render… 

    …ers etc)
    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    29efc11 View commit details
    Browse the repository at this point in the history

  9. remove a11y from individual diagrams; now happens in mermaidAPI render

    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    0adc6a6 View commit details
    Browse the repository at this point in the history

  10. doc: revise A11y: fix multi-line ex, +describedby, alpha sort examples

    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    4fb4aa4 View commit details
    Browse the repository at this point in the history

  11. doc: adding diagrams: revise a11y section

    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    9cc862b View commit details
    Browse the repository at this point in the history

  12. (minor) fix typo, whitespace formatting

    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    68b1805 View commit details
    Browse the repository at this point in the history

  13. set describeby to accessible description element id

    @weedySeaDragon
    weedySeaDragon committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    b51759d View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. format .md files

    @weedySeaDragon
    weedySeaDragon committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    6952640 View commit details
    Browse the repository at this point in the history

  2. re-re-fixed the contributing doc

    @weedySeaDragon
    weedySeaDragon committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    67a015c View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2022

  1. use optional chaining check for get acc title and get acc description 

    Co-authored-by: Alois Klink <alois@aloisklink.com>
    @weedySeaDragon @aloisklink
    weedySeaDragon and aloisklink committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    2a98791 View commit details
    Browse the repository at this point in the history

  2. export D3Element from mermaidAPI; use in accessibility

    @weedySeaDragon
    weedySeaDragon committed Nov 20, 2022
    Configuration menu
    Copy the full SHA
    a9c3373 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. Merge remote-tracking branch 'MERMAID/develop' into feat/3626-aria-de… 

    …scBy-roledescription-mocks
    @weedySeaDragon
    weedySeaDragon committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    626a474 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2022

  1. (minor) fix comment, comment typo

    @weedySeaDragon
    weedySeaDragon committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    7508cd7 View commit details
    Browse the repository at this point in the history

  2. use MockedD3, spies in util insertTitle spec (remove MockD3)

    @weedySeaDragon
    weedySeaDragon committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    f1bc2de View commit details
    Browse the repository at this point in the history

  3. add test for multi-line accDescr

    @weedySeaDragon
    weedySeaDragon committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    6e486d3 View commit details
    Browse the repository at this point in the history

  4. update /docs

    @weedySeaDragon
    weedySeaDragon committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    2030885 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Merge remote-tracking branch 'MERMAID/develop' into feat/3626-aria-de… 

    …scBy-roledescription-mocks
    @weedySeaDragon
    weedySeaDragon committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    e9d4372 View commit details
    Browse the repository at this point in the history

  2. make test title clearer

    @weedySeaDragon
    weedySeaDragon committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6044e9e View commit details
    Browse the repository at this point in the history

  3. use camelCase

    @weedySeaDragon
    weedySeaDragon committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    2bf753a View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Merge remote-tracking branch 'MERMAID/develop' into feat/3626-aria-de… 

    …scBy-roledescription-mocks

# Conflicts:
#	cypress/integration/rendering/gantt.spec.js
#	cypress/integration/rendering/requirement.spec.js
#	docs/config/setup/modules/mermaidAPI.md
#	packages/mermaid/src/accessibility.js
    @weedySeaDragon
    weedySeaDragon committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    f036d58 View commit details
    Browse the repository at this point in the history

  2. remove typeof

    @weedySeaDragon
    weedySeaDragon committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    bfe3f30 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Merge remote-tracking branch 'MERMAID/develop' into feat/3626-aria-de… 

    …scBy-roledescription-mocks
    @weedySeaDragon
    weedySeaDragon committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    96996d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Merge remote-tracking branch 'MERMAID/develop' into feat/3626-aria-de… 

    …scBy-roledescription-mocks
    @weedySeaDragon
    weedySeaDragon committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    b1dd000 View commit details
    Browse the repository at this point in the history

  2. common function for a11y; add to renderAsync; + renderAsync spec

    @weedySeaDragon
    weedySeaDragon committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    1c9a559 View commit details
    Browse the repository at this point in the history