Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve info HTML and Document assignment #4514

Merged

Conversation

Yokozuna59
Copy link
Member

@Yokozuna59 Yokozuna59 commented Jun 20, 2023

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 📓 have added documentation (if appropriate)
  • 🔖 targeted develop branch

@Yokozuna59 Yokozuna59 changed the title resolve info HTML and Document assignment resolve sandbox and info HTML and Document assignment Jun 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #4514 (1802f5d) into develop (e1379ee) will increase coverage by 0.13%.
The diff coverage is 69.56%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4514      +/-   ##
===========================================
+ Coverage    77.00%   77.14%   +0.13%     
===========================================
  Files          144      146       +2     
  Lines        14583    14675      +92     
  Branches       563      563              
===========================================
+ Hits         11230    11321      +91     
- Misses        3243     3245       +2     
+ Partials       110      109       -1     
Flag Coverage Δ
e2e 83.90% <66.66%> (+0.01%) ⬆️
unit 46.03% <66.66%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/mermaid/src/mermaidAPI.ts 62.02% <0.00%> (-0.19%) ⬇️
...ges/mermaid/src/rendering-util/selectSvgElement.ts 55.55% <55.55%> (ø)
packages/mermaid/src/diagram-api/types.ts 100.00% <100.00%> (ø)
packages/mermaid/src/diagrams/info/infoRenderer.ts 100.00% <100.00%> (+33.33%) ⬆️
packages/mermaid/src/setupGraphViewbox.js 65.47% <100.00%> (+0.41%) ⬆️

@Yokozuna59

This comment was marked as resolved.

@Yokozuna59 Yokozuna59 changed the title resolve sandbox and info HTML and Document assignment resolve info HTML and Document assignment Aug 2, 2023
@Yokozuna59 Yokozuna59 requested a review from nirname August 4, 2023 23:23
@Yokozuna59 Yokozuna59 force-pushed the resolve-info-html-assignment branch 2 times, most recently from bd9c848 to 3d53b0f Compare August 5, 2023 12:43
Copy link
Contributor

@nirname nirname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The only thing is to add a couple of tests covering that sandbox mode. Not a big deal, anyway

@Yokozuna59
Copy link
Member Author

@nirname we can't add test cases for sandbox right now because they'll fail, see #4694.

@Yokozuna59 Yokozuna59 added this pull request to the merge queue Aug 6, 2023
Merged via the queue into mermaid-js:develop with commit 7da38b9 Aug 6, 2023
12 of 13 checks passed
@Yokozuna59 Yokozuna59 deleted the resolve-info-html-assignment branch August 6, 2023 15:21
@Yokozuna59 Yokozuna59 mentioned this pull request Aug 9, 2023
4 tasks
fuxingloh pushed a commit to fuxingloh/contented that referenced this pull request Aug 15, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [mermaid](https://togithub.com/mermaid-js/mermaid) | [`10.3.0` ->
`10.3.1`](https://renovatebot.com/diffs/npm/mermaid/10.3.0/10.3.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/mermaid/10.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/mermaid/10.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/mermaid/10.3.0/10.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/mermaid/10.3.0/10.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>mermaid-js/mermaid (mermaid)</summary>

###
[`v10.3.1`](https://togithub.com/mermaid-js/mermaid/releases/tag/v10.3.1)

[Compare
Source](https://togithub.com/mermaid-js/mermaid/compare/v10.3.0...v10.3.1)

#### What's Changed

#### Bugfixes

- fix style in contributors section of intro by
[@&#8203;keer4n](https://togithub.com/keer4n) in
[mermaid-js/mermaid#4670
- fix:
[#&#8203;4676](https://togithub.com/mermaid-js/mermaid/issues/4676)
redirect fix by [@&#8203;sidharthv96](https://togithub.com/sidharthv96)
in
[mermaid-js/mermaid#4693
- [#&#8203;2139](https://togithub.com/mermaid-js/mermaid/issues/2139)
Applying user defined classes properly when calculating shape width by
[@&#8203;knsv](https://togithub.com/knsv) in
[mermaid-js/mermaid#4722
- Bug/4645 graph node containing keyword by
[@&#8203;ibrahimWassouf](https://togithub.com/ibrahimWassouf) in
[mermaid-js/mermaid#4657
- fix: Remove triple parsing of diagrams by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[mermaid-js/mermaid#4697
- resolve info `HTML` and `Document` assignment by
[@&#8203;Yokozuna59](https://togithub.com/Yokozuna59) in
[mermaid-js/mermaid#4514
- fix!(deps): fix zenuml style leakage. by
[@&#8203;danshuitaihejie](https://togithub.com/danshuitaihejie) in
[mermaid-js/mermaid#4705
- Use our prettier config on the `packages/mermaid/src/config.type.ts`
file by [@&#8203;aloisklink](https://togithub.com/aloisklink) in
[mermaid-js/mermaid#4715
- create `ParserDefinition` type by
[@&#8203;Yokozuna59](https://togithub.com/Yokozuna59) in
[mermaid-js/mermaid#4719
- standardized `error` diagram by
[@&#8203;Yokozuna59](https://togithub.com/Yokozuna59) in
[mermaid-js/mermaid#4718

#### Documentation

- Docs: Directives not needed in new diagrams as yaml formatter does
this for all new diagrams by
[@&#8203;Incognito](https://togithub.com/Incognito) in
[mermaid-js/mermaid#4688
- Docs: add latest blog post by
[@&#8203;huynhicode](https://togithub.com/huynhicode) in
[mermaid-js/mermaid#4668
- Lychee config by [@&#8203;mmorel-35](https://togithub.com/mmorel-35)
in
[mermaid-js/mermaid#4699
- Syntax Update CONTRIBUTING.md by
[@&#8203;soomrozaid](https://togithub.com/soomrozaid) in
[mermaid-js/mermaid#4713

#### Chores

- chore(deps): update all minor dependencies (minor) by
[@&#8203;renovate](https://togithub.com/renovate) in
[mermaid-js/mermaid#4682
- build(deps-dev): bump json5 from 2.2.1 to 2.2.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[mermaid-js/mermaid#4685
- build(deps): bump
[@&#8203;braintree/sanitize-url](https://togithub.com/braintree/sanitize-url)
from 6.0.0 to 6.0.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[mermaid-js/mermaid#4686
- build(deps-dev): bump vite from 4.3.3 to 4.3.9 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[mermaid-js/mermaid#4687
- chore(deps): update all patch dependencies (patch) by
[@&#8203;renovate](https://togithub.com/renovate) in
[mermaid-js/mermaid#4681
- chore: ts-ignore comment was misleading, JISON doesn't support types
by [@&#8203;Incognito](https://togithub.com/Incognito) in
[mermaid-js/mermaid#4689
- chore(deps): unpin the dompurify dependency by
[@&#8203;djadmin](https://togithub.com/djadmin) in
[mermaid-js/mermaid#4677
- build(deps-dev): bump pnpm from 8.3.1 to 8.6.8 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[mermaid-js/mermaid#4692

#### New Contributors

- [@&#8203;keer4n](https://togithub.com/keer4n) made their first
contribution in
[mermaid-js/mermaid#4670
- [@&#8203;djadmin](https://togithub.com/djadmin) made their first
contribution in
[mermaid-js/mermaid#4677
- [@&#8203;danshuitaihejie](https://togithub.com/danshuitaihejie) made
their first contribution in
[mermaid-js/mermaid#4705
- [@&#8203;soomrozaid](https://togithub.com/soomrozaid) made their first
contribution in
[mermaid-js/mermaid#4713

**Full Changelog**:
mermaid-js/mermaid@v10.3.0...v10.3.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/levaintech/contented).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants