Docs: Directives not needed in new diagrams as yaml formatter does this for all new diagrams #4688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all new diagrams
|
fyi @sidharthv96 |
Incognito
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4688 +/- ##
============================================
- Coverage 77.13% 45.32% -31.81%
============================================
Files 143 52 -91
Lines 14535 6645 -7890
Branches 516 18 -498
============================================
- Hits 11211 3012 -8199
- Misses 3219 3633 +414
+ Partials 105 0 -105
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Awesome, thank you! |
fuxingloh
pushed a commit
to fuxingloh/contented
that referenced
this pull request
Aug 15, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [mermaid](https://togithub.com/mermaid-js/mermaid) | [`10.3.0` -> `10.3.1`](https://renovatebot.com/diffs/npm/mermaid/10.3.0/10.3.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mermaid-js/mermaid (mermaid)</summary> ### [`v10.3.1`](https://togithub.com/mermaid-js/mermaid/releases/tag/v10.3.1) [Compare Source](https://togithub.com/mermaid-js/mermaid/compare/v10.3.0...v10.3.1) #### What's Changed #### Bugfixes - fix style in contributors section of intro by [@​keer4n](https://togithub.com/keer4n) in [mermaid-js/mermaid#4670 - fix: [#​4676](https://togithub.com/mermaid-js/mermaid/issues/4676) redirect fix by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4693 - [#​2139](https://togithub.com/mermaid-js/mermaid/issues/2139) Applying user defined classes properly when calculating shape width by [@​knsv](https://togithub.com/knsv) in [mermaid-js/mermaid#4722 - Bug/4645 graph node containing keyword by [@​ibrahimWassouf](https://togithub.com/ibrahimWassouf) in [mermaid-js/mermaid#4657 - fix: Remove triple parsing of diagrams by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4697 - resolve info `HTML` and `Document` assignment by [@​Yokozuna59](https://togithub.com/Yokozuna59) in [mermaid-js/mermaid#4514 - fix!(deps): fix zenuml style leakage. by [@​danshuitaihejie](https://togithub.com/danshuitaihejie) in [mermaid-js/mermaid#4705 - Use our prettier config on the `packages/mermaid/src/config.type.ts` file by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#4715 - create `ParserDefinition` type by [@​Yokozuna59](https://togithub.com/Yokozuna59) in [mermaid-js/mermaid#4719 - standardized `error` diagram by [@​Yokozuna59](https://togithub.com/Yokozuna59) in [mermaid-js/mermaid#4718 #### Documentation - Docs: Directives not needed in new diagrams as yaml formatter does this for all new diagrams by [@​Incognito](https://togithub.com/Incognito) in [mermaid-js/mermaid#4688 - Docs: add latest blog post by [@​huynhicode](https://togithub.com/huynhicode) in [mermaid-js/mermaid#4668 - Lychee config by [@​mmorel-35](https://togithub.com/mmorel-35) in [mermaid-js/mermaid#4699 - Syntax Update CONTRIBUTING.md by [@​soomrozaid](https://togithub.com/soomrozaid) in [mermaid-js/mermaid#4713 #### Chores - chore(deps): update all minor dependencies (minor) by [@​renovate](https://togithub.com/renovate) in [mermaid-js/mermaid#4682 - build(deps-dev): bump json5 from 2.2.1 to 2.2.3 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#4685 - build(deps): bump [@​braintree/sanitize-url](https://togithub.com/braintree/sanitize-url) from 6.0.0 to 6.0.1 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#4686 - build(deps-dev): bump vite from 4.3.3 to 4.3.9 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#4687 - chore(deps): update all patch dependencies (patch) by [@​renovate](https://togithub.com/renovate) in [mermaid-js/mermaid#4681 - chore: ts-ignore comment was misleading, JISON doesn't support types by [@​Incognito](https://togithub.com/Incognito) in [mermaid-js/mermaid#4689 - chore(deps): unpin the dompurify dependency by [@​djadmin](https://togithub.com/djadmin) in [mermaid-js/mermaid#4677 - build(deps-dev): bump pnpm from 8.3.1 to 8.6.8 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#4692 #### New Contributors - [@​keer4n](https://togithub.com/keer4n) made their first contribution in [mermaid-js/mermaid#4670 - [@​djadmin](https://togithub.com/djadmin) made their first contribution in [mermaid-js/mermaid#4677 - [@​danshuitaihejie](https://togithub.com/danshuitaihejie) made their first contribution in [mermaid-js/mermaid#4705 - [@​soomrozaid](https://togithub.com/soomrozaid) made their first contribution in [mermaid-js/mermaid#4713 **Full Changelog**: mermaid-js/mermaid@v10.3.0...v10.3.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/levaintech/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
As a result of a discussion in a PR, I wanted to clean up the "add a new diagram" documentation.
#4678 (comment)
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch