feat: add pie langium parser

[Yokozuna59]

📑 Summary

• Create pie langium parser and integrate it in packages/mermaid.
• ignore yaml, comments, and directives in pie grammar

BREAKING CHANGES

• Remove cleanValue from pieDb.
• Rename D3Sections into D3Section
• Change addSection header into D3Section type

Issues

• Resolves Pie chart is not rendered when we provide any other value except positive number #2472
• Partially feat(parser): reimplement parser in langium instead of jison #4401

📏 Design Decisions

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a344d88) 44.54% compared to head (25cd86f) 44.54%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #4751   +/-   ##
=======================================
  Coverage   44.54%   44.54%           
=======================================
  Files          25       25           
  Lines        5246     5246           
  Branches       27       27           
=======================================
  Hits         2337     2337           
  Misses       2908     2908           
  Partials        1        1           

Flag	Coverage Δ
unit	44.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[Yokozuna59]

I think we should change sections type into list of D3Section:

mermaid/packages/mermaid/src/diagrams/pie/pieDb.ts

Line 23 in 1c8e13b

sections: {},

mermaid/packages/mermaid/src/diagrams/pie/pieTypes.ts

Lines 39 to 42 in 1c8e13b

	export interface D3Sections {
	label: string;
	value: number;
	}

Since it's what d3 uses:

mermaid/packages/mermaid/src/diagrams/pie/pieRenderer.ts

Lines 14 to 21 in 1c8e13b

	const pieData: D3Sections[] = Object.entries(sections).map(
	(element: [string, number]): D3Sections => {
	return {
	label: element[0],
	value: element[1],
	};
	}
	);

And the returned value from mermaid-parser:

export interface PieSection extends AstNode {
    readonly $container: Pie;
    readonly $type: 'PieSection';
    label: string;
    value: number;
}

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	25cd86f
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/65c8e038cf77b7000894d7b8
😎 Deploy Preview	https://deploy-preview-4751--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Yokozuna59]

@sidharthv96 seeing that you renamed some files in 11b60ce, should we rename all other files?

[sidharthv96]

@sidharthv96 seeing that you renamed some files in 11b60ce, should we rename all other files?

Renaming the files might not be a bad idea.

#4499 (comment)

[Yokozuna59]

@sidharthv96 suggested comments are applied.

Should we add the AstNode omit type and use it or not? And what about this comment #4751 (comment).

[sidharthv96]

@Yokozuna59 Hope the exams were a breeze :)
Merging this to next, we can add the new approach as you mentioned there.

[Yokozuna59]

@sidharthv96 I merged packet diagram changes to this PR, some modification has been to that approach so it would inline with the current one, e.g., remove Lexer and use EOL.

[Yokozuna59]

@sidharthv96 Do you know why the ZenUML Cypress test keeps failing? I haven't modified it files.

[Yokozuna59]

@sidharthv96 Any updates on this PR? It's currently blocking #4799 and other parsers future PRs. I plan to work on the mindmap diagram since its files have been converted to TS in #5247, but I need the changes that have been implemented in this PR.

[sidharthv96]

Is the E2E failure valid?

[Yokozuna59]

They’re, although I’m not sure why because I haven’t touched ZenUml files.