Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PH changes #4903

Merged
merged 2 commits into from Oct 11, 2023
Merged

Revert PH changes #4903

merged 2 commits into from Oct 11, 2023

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Oct 4, 2023

To be merged after the PH launch day.

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 94308fe
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/651d2a73439d9a0008f44e22
😎 Deploy Preview https://deploy-preview-4903--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sidharthv96 sidharthv96 marked this pull request as draft October 4, 2023 09:01
@sidharthv96 sidharthv96 self-assigned this Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #4903 (94308fe) into master (f1895ac) will decrease coverage by 0.26%.
Report is 195 commits behind head on master.
The diff coverage is 65.84%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4903      +/-   ##
==========================================
- Coverage   76.03%   75.78%   -0.26%     
==========================================
  Files         146      139       -7     
  Lines       14569    12859    -1710     
  Branches      592      592              
==========================================
- Hits        11078     9745    -1333     
+ Misses       3368     2992     -376     
+ Partials      123      122       -1     
Flag Coverage Δ
e2e 79.92% <77.08%> (-2.63%) ⬇️
unit 43.67% <24.45%> (-1.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/config.ts 68.82% <100.00%> (-5.67%) ⬇️
packages/mermaid/src/dagre-wrapper/index.js 98.82% <100.00%> (ø)
packages/mermaid/src/dagre-wrapper/markers.js 100.00% <100.00%> (ø)
packages/mermaid/src/dagre-wrapper/nodes.js 63.79% <100.00%> (-25.83%) ⬇️
packages/mermaid/src/diagram-api/comments.ts 100.00% <100.00%> (+12.50%) ⬆️
...s/mermaid/src/diagram-api/diagram-orchestration.ts 83.33% <ø> (+43.79%) ⬆️
packages/mermaid/src/diagram-api/diagramAPI.ts 90.47% <100.00%> (+20.85%) ⬆️
packages/mermaid/src/diagrams/c4/c4Db.js 65.27% <ø> (+0.07%) ⬆️
packages/mermaid/src/diagrams/c4/c4Diagram.ts 100.00% <100.00%> (ø)
packages/mermaid/src/diagrams/class/classDb.ts 83.33% <100.00%> (+0.44%) ⬆️
... and 33 more

... and 45 files with indirect coverage changes

@sidharthv96 sidharthv96 marked this pull request as ready for review October 11, 2023 06:02
@sidharthv96 sidharthv96 merged commit d1b386b into master Oct 11, 2023
23 of 27 checks passed
@sidharthv96 sidharthv96 deleted the sidv/removeBanner branch October 11, 2023 06:02
@sidharthv96 sidharthv96 mentioned this pull request Oct 11, 2023
4 tasks
fuxingloh pushed a commit to fuxingloh/contented that referenced this pull request Oct 25, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [mermaid](https://togithub.com/mermaid-js/mermaid) | [`10.5.0` ->
`10.5.1`](https://renovatebot.com/diffs/npm/mermaid/10.5.0/10.5.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/mermaid/10.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/mermaid/10.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/mermaid/10.5.0/10.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/mermaid/10.5.0/10.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>mermaid-js/mermaid (mermaid)</summary>

###
[`v10.5.1`](https://togithub.com/mermaid-js/mermaid/releases/tag/v10.5.1)

[Compare
Source](https://togithub.com/mermaid-js/mermaid/compare/v10.5.0...v10.5.1)

#### What's Changed

- Fix: Fix for subgraphs when using flowchart-elk by
[@&#8203;knsv](https://togithub.com/knsv)
- Docs: update Latest News section by
[@&#8203;huynhicode](https://togithub.com/huynhicode) in
[mermaid-js/mermaid#4822
- Docs: update Ecosystem section by
[@&#8203;huynhicode](https://togithub.com/huynhicode) in
[mermaid-js/mermaid#4817
- Docs: update Latest News section (Git Graph blog post) by
[@&#8203;huynhicode](https://togithub.com/huynhicode) in
[mermaid-js/mermaid#4871
- Docs: Add Product Hunt info by
[@&#8203;huynhicode](https://togithub.com/huynhicode) in
[mermaid-js/mermaid#4900
- Revert PH changes by
[@&#8203;sidharthv96](https://togithub.com/sidharthv96) in
[mermaid-js/mermaid#4903

**Full Changelog**:
mermaid-js/mermaid@v10.5.0...v10.5.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/levaintech/contented).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant