Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #5064 Handle case when line has only one point #5065

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

sidharthv96
Copy link
Member

📑 Summary

There was an edge case where the edge line only has a single point (not a "line" anymore).

📏 Design Decisions

This patch only bypasses the newly introduced bug, why a line is created with just a point needs to be investigated further.

📋 Tasks

Make sure you

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 7b0f6c1
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6560313296472600080fb07e
😎 Deploy Preview https://deploy-preview-5065--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #5065 (7b0f6c1) into develop (8f733c6) will decrease coverage by 1.27%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5065      +/-   ##
===========================================
- Coverage    77.35%   76.09%   -1.27%     
===========================================
  Files          164      164              
  Lines        13869    13882      +13     
  Branches       698      700       +2     
===========================================
- Hits         10728    10563     -165     
- Misses        2987     3162     +175     
- Partials       154      157       +3     
Flag Coverage Δ
e2e 81.18% <0.00%> (-1.59%) ⬇️
unit 42.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/utils/lineWithOffset.ts 63.82% <0.00%> (-27.35%) ⬇️

... and 9 files with indirect coverage changes

* develop:
  fix broken link
  add latest blog post
  fix linting
  fix: set proper shiki theme for light and dark modes
  fix: change shiki theme to github-light
  add latest blog post
  add latest blog post
@sidharthv96 sidharthv96 added this pull request to the merge queue Nov 24, 2023
Merged via the queue into develop with commit 61747b6 Nov 24, 2023
25 of 26 checks passed
@sidharthv96 sidharthv96 deleted the 5064_EdgeOffsetEdgeCase branch November 24, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'x')
1 participant