Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Updated Doc links for mermaid-chart #5137

Closed
wants to merge 2 commits into from

Conversation

Abrifq
Copy link
Contributor

@Abrifq Abrifq commented Dec 12, 2023

πŸ“‘ Summary

Updated file packages/mermaid/src/docs/ecosystem/mermaid-chart.md and rebuilt the docs.

Resolves "Link checker failed" mails πŸ™‚

πŸ“ Design Decisions

none

πŸ“‹ Tasks

Make sure you

  • πŸ“– have read the contribution guidelines
  • ❌ πŸ’» have added necessary unit/e2e tests.
  • ❌ πŸ““ have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • πŸ”– targeted develop branch

Copy link

netlify bot commented Dec 12, 2023

βœ… Deploy Preview for mermaid-js ready!

Name Link
πŸ”¨ Latest commit d00c87c
πŸ” Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65785c05703e3100087d8427
😎 Deploy Preview https://deploy-preview-5137--mermaid-js.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #5137 (d00c87c) into develop (6e64556) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5137   +/-   ##
========================================
  Coverage    79.37%   79.37%           
========================================
  Files          166      166           
  Lines        13878    13878           
  Branches       705      705           
========================================
  Hits         11016    11016           
  Misses        2710     2710           
  Partials       152      152           
Flag Coverage Ξ”
e2e 85.18% <ΓΈ> (ΓΈ)
unit 43.04% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

@huynhicode
Copy link
Member

Ah sorry @Abrifq - there have been recent updates to this page.

The Plugins section verbiage was recently updated.

https://mermaid.js.org/ecosystem/mermaid-chart.html

Screenshot 2023-12-19 at 1 05 26 PM

@huynhicode
Copy link
Member

I am going to close your PR. Thanks for spotting the broken link and I hope you continue to contribute!

@huynhicode huynhicode closed this Dec 19, 2023
@Abrifq Abrifq deleted the link-checker-updates branch December 20, 2023 06:13
@Abrifq
Copy link
Contributor Author

Abrifq commented Dec 20, 2023

Thank you for checking the PR. Can you also check #5151?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants