docs/5199 Docs docker section run commands #5201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker instructions for the runscript seem to not work: ``` ./run install # npx pnpm install ./run test # pnpm test ``` This PR replaces them with the working ones: ``` ./run pnpm install ./run pnpm test ```
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5201 +/- ##
========================================
Coverage 43.04% 43.04%
========================================
Files 23 23
Lines 5018 5018
Branches 21 21
========================================
Hits 2160 2160
Misses 2857 2857
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@sidharthv96 This must be closed because #5132 already covers the case and original issue had been already closed by the same reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker instructions for the runscript seem to not work:
This PR replaces them with the working ones:
📑 Summary
Brief description about the content of your PR.
Resolves #<5199>
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch