Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Semicolons in Timeline Titles, Sections, Periods, and Events #5335

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Allow Semicolons in Timeline Titles, Sections, Periods, and Events #5335

wants to merge 7 commits into from
+20 −4

Commits on Feb 27, 2024

  1. Changes to timeline.jison 

    1. Removed the semicolon from the regex for titles, sections, periods, and events.
Changes to timeline.spec.js
1. Added a test for the changes made in the timeline parser
    @FutzMonitor
    FutzMonitor committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1169cb9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into 4175Issue-allowSemicolons

    @FutzMonitor
    FutzMonitor committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f13beab View commit details
    Browse the repository at this point in the history

  3. Run the pnpm lint:fix command to fix linting problems

    @FutzMonitor
    FutzMonitor committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9e3ebf1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into 4175Issue-allowSemicolons

    @FutzMonitor
    FutzMonitor committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    fab6987 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge branch 'develop' into 4175Issue-allowSemicolons

    @FutzMonitor
    FutzMonitor committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e433b95 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Changes to timeline.spec.js 

    1. Re-organized the new TL-6 test to not use a for-loop with a switch case.
2. Imported the commonDb module to ensure titles are be tested.
3. Use indices to retrieve elements that need to be tested.
    @FutzMonitor
    FutzMonitor committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    cf88f06 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Merge branch 'develop' into 4175Issue-allowSemicolons

    @FutzMonitor
    FutzMonitor committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    c239b6e View commit details
    Browse the repository at this point in the history