Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Colon Characters in Period, Sections, and Event Text #5418

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Allow Colon Characters in Period, Sections, and Event Text #5418

wants to merge 5 commits into from
+30 −4

Commits on Mar 26, 2024

  1. Changes made to svgDraw.js 

    1. Added function replaceEscapedColon() to replace all instances of 'ESC_COLON' with colons.
2. Added a call to this function within the drawText() function to replace any text that contains  to a colon.
3. AUTHOR'S NOTE: These changes only apply for sections, periods, and event elements. This functionality does not work for timeline titles.
Changes to timeline.md
1. Updated documentation to guide users on how to include colon characters in their text.
    @FutzMonitor
    FutzMonitor committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    c37d3a6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into 4175Issue

    @FutzMonitor
    FutzMonitor committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    70707cd View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Changes to rendering/timeline.spec.ts 

    1. Added test coverage to rendering changes where 'ESC_COLON' should be changed to a colon character and this change should not break rendering behavior.
    @FutzMonitor
    FutzMonitor committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    f4de050 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Merge branch 'develop' into 4175Issue

    @FutzMonitor
    FutzMonitor committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    bc1b4ca View commit details
    Browse the repository at this point in the history

  2. Changes to rendering/timeline.spec.ts 

    1. Changes the test title because it was previously inaccurate
    @FutzMonitor
    FutzMonitor committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e529cbd View commit details
    Browse the repository at this point in the history