Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call .node to check for node existence #5448

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: call .node to check for node existence #5448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f5f48e
fix: call .node to check for node existence
FezVrasta Apr 8, 2024
ff34dbc
check for text element node existance
FezVrasta Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/mermaid/src/diagrams/sequence/svgDraw.js
View file
Open in desktop
Expand Up @@ -243,12 +243,15 @@
} else {
textElem.text(text);
}

const textElemNode = (textElem._groups || textElem)[0][0]
if (
textElemNode &&
textData.valign !== undefined &&
textData.textMargin !== undefined &&
textData.textMargin > 0
) {
textHeight += (textElem._groups || textElem)[0][0].getBBox().height;
textHeight += textElemNode.getBBox().height;
prevTextHeight = textHeight;
}

Expand Down Expand Up @@ -401,7 +404,7 @@
);

let height = actor.height;
if (rectElem.node) {
if (rectElem.node()) {

Check failure on line 407 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when parsing a sequenceDiagram > should not show sequence numbers per default 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:407:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:516:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:212:5

Check failure on line 407 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when parsing a sequenceDiagram > should show sequence numbers when autonumber is enabled 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:407:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:516:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:224:5

Check failure on line 407 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > it should handle one actor, when textPlacement is tspan 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:407:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:516:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1651:7

Check failure on line 407 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > it should handle one actor, when textPlacement is fo 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:407:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:516:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1651:7

Check failure on line 407 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > it should handle one actor, when textPlacement is old 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:407:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:516:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1651:7

Check failure on line 407 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > it should handle one actor, when textPlacement is undefined 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:407:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:516:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1651:7

Check failure on line 407 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > should handle one actor and a centered note 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:407:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:516:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1682:5

Check failure on line 407 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > should handle one actor and a note to the left 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:407:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:516:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1698:5

Check failure on line 407 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > should handle one actor and a note to the right 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:407:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:516:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1714:5

Check failure on line 407 in packages/mermaid/src/diagrams/sequence/svgDraw.js

View workflow job for this annotation

GitHub Actions / unit-test

packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js > when rendering a sequenceDiagram APA > should handle two actors 

TypeError: rectElem.node is not a function
 ❯ drawActorTypeParticipant packages/mermaid/src/diagrams/sequence/svgDraw.js:407:16
 ❯ Object.drawActor packages/mermaid/src/diagrams/sequence/svgDraw.js:516:14
 ❯ drawActors packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:563:7
 ❯ Object.draw packages/mermaid/src/diagrams/sequence/sequenceRenderer.ts:1048:3
 ❯ packages/mermaid/src/diagrams/sequence/sequenceDiagram.spec.js:1729:5
const bounds = rectElem.node().getBBox();
actor.height = bounds.height;
height = bounds.height;
Expand Down