Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unrefSubSchemas #5514

Merged
merged 1 commit into from May 13, 2024
Merged

Conversation

sidharthv96
Copy link
Member

📑 Summary

Removes unrefSubSchemas as it was a cosmetic hack to reduce git diff changes.

📋 Tasks

Make sure you

Copy link

netlify bot commented May 13, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit c993adf
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66419b0500e3a10008b8ce79
😎 Deploy Preview https://deploy-preview-5514--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 5.74%. Comparing base (4885b31) to head (c993adf).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5514      +/-   ##
==========================================
+ Coverage     5.72%   5.74%   +0.01%     
==========================================
  Files          278     277       -1     
  Lines        42046   41967      -79     
  Branches       490     515      +25     
==========================================
  Hits          2409    2409              
+ Misses       39637   39558      -79     
Flag Coverage Δ
unit 5.74% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../mermaid/scripts/create-types-from-json-schema.mts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@sidharthv96 sidharthv96 marked this pull request as ready for review May 13, 2024 04:59
@sidharthv96 sidharthv96 merged commit 0326d89 into develop May 13, 2024
29 of 33 checks passed
@sidharthv96 sidharthv96 deleted the sidv/removeUnrefSubschemas branch May 13, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants