Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flowchart.md #5517

Merged
merged 2 commits into from May 16, 2024
Merged

Update flowchart.md #5517

merged 2 commits into from May 16, 2024

Conversation

GRASBOCK
Copy link
Contributor

fix callback by setting the window callback to the respective callback function in the jsfiddle and code sample

📑 Summary

The documentation jsfiddle on flowchart interaction doesn't work, because the callback function is not added.
I fixed the code samples and the jsfiddle and replaced the old jsfiddle with a link to the new one.

Resolves #5510

📏 Design Decisions

Saved a new jsfiddle that contains the change and made the changes in the markdown of the docs.

📋 Tasks

Make sure you

Copy link

netlify bot commented May 13, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 6d2939c
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66459606e0165b00087212a5
😎 Deploy Preview https://deploy-preview-5517--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0.97143% with 1733 lines in your changes are missing coverage. Please review.

Project coverage is 5.73%. Comparing base (c562ca0) to head (356e520).
Report is 15 commits behind head on master.

❗ Current head 356e520 differs from pull request most recent head 6d2939c. Consider uploading reports for the commit 6d2939c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5517      +/-   ##
=========================================
- Coverage    5.74%   5.73%   -0.01%     
=========================================
  Files         276     278       +2     
  Lines       41886   41978      +92     
  Branches      514     490      -24     
=========================================
+ Hits         2407    2409       +2     
- Misses      39479   39569      +90     
Flag Coverage Δ
unit 5.73% <0.97%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.build/jisonTransformer.ts 0.00% <ø> (ø)
packages/mermaid-flowchart-elk/src/render-utils.ts 0.00% <ø> (ø)
packages/mermaid-flowchart-elk/src/styles.ts 0.00% <ø> (ø)
packages/mermaid-zenuml/src/parser.ts 0.00% <ø> (ø)
packages/mermaid/src/defaultConfig.ts 45.65% <100.00%> (ø)
...ackages/mermaid/src/diagrams/error/errorDiagram.ts 0.00% <ø> (ø)
packages/mermaid/src/diagrams/gantt/ganttDb.js 77.47% <100.00%> (ø)
packages/mermaid/src/config.ts 52.22% <50.00%> (ø)
packages/mermaid/src/dagre-wrapper/clusters.js 0.00% <0.00%> (ø)
...kages/mermaid/src/dagre-wrapper/intersect/index.js 0.00% <0.00%> (ø)
... and 66 more

... and 1 file with indirect coverage changes

GRASBOCK and others added 2 commits May 16, 2024 10:43
fix callback by setting the window callback to the respective callback function in the jsfiddle and code sample
@sidharthv96 sidharthv96 changed the base branch from develop to master May 16, 2024 05:13
@sidharthv96
Copy link
Member

Switching from develop to master so docs can be out immediately.

@sidharthv96 sidharthv96 merged commit 362e49a into mermaid-js:master May 16, 2024
16 of 17 checks passed
Copy link

mermaid-bot bot commented May 16, 2024

@GRASBOCK, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flowchart interaction docs fail: o[n] is not a function
2 participants