Feat/editable participant #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the following case, the expected result should be Screen.Recording.2024-05-02.at.10.26.44.PM.mov |
MrCoder
requested changes
May 2, 2024
Fixed |
|
First part is on the main branch where Screen.Recording.2024-05-04.at.9.01.14.AM.mov |
MrCoder
reviewed
May 4, 2024
| @@ -46,21 +64,29 @@ ToCollector.enterParticipant = onParticipant; | |||
| let onTo = function (ctx) { | |||
| if (isBlind) return; | |||
| let participant = ctx.getFormattedText(); | |||
| participants.Add(participant); | |||
| const participantInstance = participants.Get(participant); | |||
There was a problem hiding this comment.
Same logic needs to be implemented in enterCreation?
There was a problem hiding this comment.
Alrighty. Added same label check in enterCreation.
MrCoder
reviewed
May 4, 2024
MrCoder
reviewed
May 4, 2024
dontry
force-pushed
the
feat/editable-participant
branch
from
ff87b1d
to
8a59877
Compare
|
Address the issue of calling a method after creating a new instance and assigning to a new variable Screen.Recording.2024-05-17.at.10.06.36.PM.mov |
MrCoder
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables users to edit participant name:
Add a new member
participantPositionstoPariticipantsclass.participantPositionsis a map where to keep track of participant names and their positions.Record participant's position when traversing the parseTree.
Create a new component
PariticipantLabelfor editing label names and updating the participant instances in codeDisable edit in static render mode
Screen.Recording.2024-05-02.at.9.53.36.pm.mov