Add blog-storage-demo to Turbine Go examples #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayjayjpg
reviewed
Mar 24, 2023
| var outputStream []turbine.Record | ||
|
|
||
| webhookURL := "https://webhook.site/ac38ce4e-c50a-4a56-b098-8b038890d94f" | ||
| baseURL := "https://meroxas3bucket.s3.us-east-2.amazonaws.com/" |
There was a problem hiding this comment.
Are the bucket and the webhook publicly available? If yes, we could maybe hide the values via secrets. This way, anyone who browses the repo wouldn't be able to use those urls to write to them themselves:
E.g.
- using
RegisterSecret: https://github.com/meroxa/sfdc-sync/blob/main/app.go#L52 - retrieve secret in the app: https://github.com/meroxa/sfdc-sync/blob/main/app.go#L141
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Blog Storage Demo (S3 to Postgres) to example Go apps.