Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace and org #10884

Merged
merged 14 commits into from
May 14, 2024
Merged

Workspace and org #10884

merged 14 commits into from
May 14, 2024

Conversation

captain-Akshay
Copy link
Contributor

@captain-Akshay captain-Akshay commented May 7, 2024

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

leecalcote and others added 4 commits May 7, 2024 07:29
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
leecalcote
leecalcote previously approved these changes May 7, 2024
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well in my tests.

It would be ideal to see a screenshot of the empty state (of an expired session or missing org id).

@leecalcote
Copy link
Member

@captain-Akshay Here is my experience while using the Local Provider:

Screenshot 2024-05-07 at 2 53 41 PM

Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
@captain-Akshay
Copy link
Contributor Author

Duplication is an issue I will try to fix it

@betelgeuse-code
Copy link
Contributor

Duplication is an issue I will try to fix it

This duplication happens because of bad logic in the server itself, whenever Meshery boots it registers a new org, @captain-Akshay this is server specific issue not on UI

Copy link
Contributor

@betelgeuse-code betelgeuse-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ui/components/SpacesSwitcher/SpaceSwitcher.js Outdated Show resolved Hide resolved
@leecalcote
Copy link
Member

Duplication is an issue I will try to fix it

This duplication happens because of bad logic in the server itself, whenever Meshery boots it registers a new org, @captain-Akshay this is server specific issue not on UI

Where has the issue been filed to fix the poor Server behavior? Merging this PR only exacerbates exposure of this poor behavior.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must use styled components.

This is something that @captain-Akshay already knows (or at least has already been informed of multiple times).

@leecalcote
Copy link
Member

Must use styled components.

This is something that @captain-Akshay already knows (or at least has already been informed of multiple times).

@captain-Akshay please fix today.

@leecalcote
Copy link
Member

Duplication is an issue I will try to fix it

This duplication happens because of bad logic in the server itself, whenever Meshery boots it registers a new org, @captain-Akshay this is server specific issue not on UI

Open a new issue, please.

@Yashsharma1911
Copy link
Contributor

Yashsharma1911 commented May 8, 2024

Duplication is an issue I will try to fix it

This duplication happens because of bad logic in the server itself, whenever Meshery boots it registers a new org, @captain-Akshay this is server specific issue not on UI

Open a new issue, please.

Issue is alreay being opened here - #10594, I will raise a fix today

@Yashsharma1911
Copy link
Contributor

Duplication is an issue I will try to fix it

This duplication happens because of bad logic in the server itself, whenever Meshery boots it registers a new org, @captain-Akshay this is server specific issue not on UI

Open a new issue, please.

Issue is alreay being opened here - #10594, I will raise a fix today

I raised a fix Here - https://github.com/meshery/meshery/pull/10899/files

Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
@leecalcote
Copy link
Member

@captain-Akshay what Meshery Docs did you update based on this change?

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build warning:

./components/Header.js
457:21  Warning: Missing "key" prop for element in iterator 

Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
@leecalcote leecalcote merged commit 49696d4 into meshery:master May 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants