-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace and org #10884
Workspace and org #10884
Conversation
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well in my tests.
It would be ideal to see a screenshot of the empty state (of an expired session or missing org id).
@captain-Akshay Here is my experience while using the Local Provider: |
Duplication is an issue I will try to fix it |
This duplication happens because of bad logic in the server itself, whenever Meshery boots it registers a new org, @captain-Akshay this is server specific issue not on UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Where has the issue been filed to fix the poor Server behavior? Merging this PR only exacerbates exposure of this poor behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must use styled components.
This is something that @captain-Akshay already knows (or at least has already been informed of multiple times).
@captain-Akshay please fix today. |
Open a new issue, please. |
Issue is alreay being opened here - #10594, I will raise a fix today |
I raised a fix Here - https://github.com/meshery/meshery/pull/10899/files |
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
@captain-Akshay what Meshery Docs did you update based on this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build warning:
./components/Header.js
457:21 Warning: Missing "key" prop for element in iterator
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
Notes for Reviewers
This PR fixes #
Signed commits