Err comp config pairs code #10895
Err comp config pairs code #10895
Conversation
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
|
|
|
🚀 Preview for commit 04e8b86 at: https://663b26842cc488d107b159c0--meshery-docs-preview.netlify.app |
| "suggested_remediation": "" | ||
| "long_description": "An error occurred while trying to create Component Configuration.", | ||
| "short_description": "Unable to Create Component Configuration.", | ||
| "probable_cause": "Missing or invalid user token, invalid Kubernetes handler or serviceActionProvider error.", |
There was a problem hiding this comment.
Refactor to make this user-facing. To a user, what is a Kubernetes handler or serviceActionProvider?
Users know about Meshery Connections and can be offered a link to troubleshooting or understanding connections and Meshery's interactions with Kubernetes (in Meshery Docs), but they will not understand references to function names or golang routines.
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
Signed-off-by: Jougan-0 <prasantmishra2018@gmail.com>
|
🚀 Preview for commit 06c4a8c at: https://664391e13eb358009ebe2e20--meshery-docs-preview.netlify.app |
|
should MeshMap Screenshot Service / MeshMapScreenshot (pull_request_target) |
|
🚀 Preview for commit b9a0b29 at: https://664e2de3ab580a0417858800--meshery-docs-preview.netlify.app |
| @@ -207,9 +207,8 @@ func ErrExecutionPlan(err error) error { | |||
| } | |||
|
|
|||
| func ErrCompConfigPairs(err error) error { | |||
| return errors.New(ErrCompConfigPairsCode, errors.Alert, []string{"unable to Create Comp Config.", err.Error()}, []string{err.Error()}, []string{}, []string{}) | |||
| return errors.New(ErrCompConfigPairsCode, errors.Alert, []string{"Unable to Create Component Configuration.", err.Error()}, []string{("An error occurred while trying to create Component Configuration."), err.Error()}, []string{"Missing or invalid user token, or an issue with Meshery's interactions with Kubernetes."}, []string{"For understanding and troubleshooting, refer to https://docs.meshery.io/guides/troubleshooting and https://docs.meshery.io/installation/kubernetes"}) | |||
There was a problem hiding this comment.
Add name of the component for which it failed, (its kind and name).
"Missing or invalid user token, or an issue with Meshery's interactions with Kubernetes."
only single cause?
- No registered model/comp found inside registry
- failed validation
Will you verify what error you get if we try to deploy a CR inside a cluster which doesn't have a CRD deployed.
What error you get from meshery vs when you do same from kubectl
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10895 +/- ##
=======================================
Coverage 9.01% 9.01%
=======================================
Files 146 146
Lines 19258 19258
=======================================
Hits 1736 1736
Misses 17220 17220
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Notes for Reviewers
This PR fixes #10762
Update documentation and error codes in Go by including missing long descriptions, probable causes, and suggested remedy.
Signed commits