-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: list relationships cmd #10898
base: master
Are you sure you want to change the base?
Feat: list relationships cmd #10898
Conversation
Signed-off-by: Eti Ijeoma <53005190+Aijeyomah@users.noreply.github.com>
} | ||
|
||
relationshipsResponse := &models.MeshmodelRelationshipsAPIResponse{} | ||
err = json.Unmarshal(data, relationshipsResponse) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you ran the command ?
Here it is giving error for me.
return err | ||
} | ||
|
||
header := []string{"Entity Details", "Type"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer here to see the columns we need to display.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer here to see the columns we need to display.
Alright, thanks
return nil | ||
} | ||
|
||
if cmd.Flags().Changed("page") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me hitting enter causes issue .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me hitting enter causes issue .
Sorry about that, I still in draft because I was waiting for the interactive pagination to be merged and it was yesterday. I'm working on completing it today
Notes for Reviewers
This PR fixes #9844
Signed commits