Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete stuck pods in valid_namespaces #10904

Merged
merged 2 commits into from
May 28, 2024

Conversation

MUzairS15
Copy link
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: MUzairS15 <muzair.shaikh810@gmail.com>
Copy link

github-actions bot commented May 8, 2024

leecalcote
leecalcote previously approved these changes May 8, 2024
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’ll work! 🤠

@cpepper96
Copy link
Member

So this will just list all the pods that are not currently running or being created right? @MUzairS15

@leecalcote
Copy link
Member

So this will just list all the pods that are not currently running or being created right? @MUzairS15

@cpepper96, good eye. I don't know that this PR takes us to conclusion with a deletion of unwanted Pods....

@MUzairS15
Copy link
Contributor Author

So this will just list all the pods that are not currently running or being created right? @MUzairS15

Yes

@leecalcote
Copy link
Member

in that case, how is this helpful?

@MUzairS15
Copy link
Contributor Author

MUzairS15 commented May 15, 2024

The PR is for deleting stuck/crashing pods in namespaces we don’t delete (valid namespaces) hence freeing up resources.

@MUzairS15
Copy link
Contributor Author

For resources (or pods) in other namespaces we are deleting the entire namespace hence covered.

@cpepper96
Copy link
Member

I feel like I'm missing something here 😆

@MUzairS15 are you planning on adding to this script to delete the stuck pods or just list them? Sidenote, can we just wipe the whole default namespace each night? Is there anything being deployed there that we want to persist?

Signed-off-by: Mohd Uzair <muzair.shaikh810@gmail.com>
@MUzairS15
Copy link
Contributor Author

I feel like I'm missing something here 😆

@MUzairS15 are you planning on adding to this script to delete the stuck pods or just list them? Sidenote, can we just wipe the whole default namespace each night? Is there anything being deployed there that we want to persist?

Thanks for pointing out. I was testing if the command is able to select required pods correctly and later forgot to replace get with delete. 😅

@MUzairS15
Copy link
Contributor Author

MUzairS15 commented May 16, 2024

Yes we can, but still there can be stale pods in other namespaces.

@leecalcote
Copy link
Member

@MUzairS15 should this be marked as draft or work-in-progress?

@MUzairS15
Copy link
Contributor Author

It is completed

Copy link
Member

@cpepper96 cpepper96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MUzairS15 MUzairS15 merged commit 83431c8 into meshery:master May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants