Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI]: Filters page migration to rtk-query hooks #10905

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[UI]: Filters page migration to rtk-query hooks #10905

wants to merge 3 commits into from

Conversation

dottharun
Copy link
Contributor

@dottharun dottharun commented May 9, 2024 •
edited

Notes for Reviewers

This PR is related to #9985

Converted API:

Thoughts:

  • Should the ACTION_TYPES object be removed in favor of builtin errors ?
  • Is there any alternative for excessive prop drilling ?

Checklist for reviewers

  • Do all child components use RTK store, and the old store's state-dispatch props are correctly passed to them ?
  • Proper usage of rtk-query hook.
  • Errors and data handling from the rtk-query hook.

Signed commits

  • Yes, I signed my commits.

@dottharun
refactor: filter dataFetch to rtk-query
ff118ae 
Signed-off-by: Tharun T <tharun242424@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited

@dottharun
refactor: using rtk store for MesheryFilters
4237e19 
and using props for passing state and dispatch to confirmationMsg

Signed-off-by: Tharun T <tharun242424@gmail.com>
@leecalcote
Copy link
Member

Ready for review, @dottharun?

@leecalcote
Copy link
Member

@dottharun, if so, please remove the draft label.

@dottharun dottharun marked this pull request as ready for review May 14, 2024 00:29
@leecalcote
Copy link
Member

@dottharun please finish this before opening more PRs.

@dottharun dottharun marked this pull request as draft May 23, 2024 06:59
@dottharun
revert: schema rtk-query
d583a68 
This reverts commit ff118ae.

Signed-off-by: Tharun T <tharun242424@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudhanshutech sudhanshutech Awaiting requested review from sudhanshutech

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component/ui User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dottharun @leecalcote