Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mesheryctl] Removal of the onboard Sub-command from Mesheryctl Pattern Command #10929

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

singh1203
Copy link
Contributor

Notes for Reviewers

This PR fixes #10886

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the component/mesheryctl CLI for Meshery label May 11, 2024
Copy link

github-actions bot commented May 11, 2024

@singh1203 singh1203 marked this pull request as ready for review May 11, 2024 15:24
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singh1203 will you list the various test scenarios that you've tried and their results?

@singh1203
Copy link
Contributor Author

@singh1203 will you list the various test scenarios that you've tried and their results?

Currently haven't tested various scenarios, but will prioritize doing so ASAP and exploring different tests I can run.

@leecalcote
Copy link
Member

Any scenarios and results to report, @singh1203?

@singh1203
Copy link
Contributor Author

singh1203 commented May 17, 2024

Any scenarios and results to report, @singh1203?

Certainly! Here is a list of the various test scenarios and their results for the mesheryctl pattern command:

mesheryctl pattern apply

  • Applying with ID

    • Result: Failed
    • Issue: No pattern found with the given name or ID.
    • Error Message: "Fetching patterns... No Pattern found with the given name or ID."
  • Applying with file path

    • Result: Partially successful
    • Issue: Pattern is created but not deployed.
    • Error Message: "Applying pattern Simple Kubernetes Pod. Response Status Code 500, possibly Server error."
  • Index problem

    • Result: Failed
    • Issue: When providing an index, it shows "Already implemented with [pattern name]".
  • Documentation issues

    • Issue: Missing proper documentation for the command syntax (e.g., mesheryctl pattern apply [patternID]).

mesheryctl pattern import

mesheryctl pattern delete

  • Deleting with patternID

    • Result: Successful
    • Issue: None
  • Deleting with file path

    • Result: Failed
    • Issue: Response Status Code 500, possibly Server error.
    • Error Message: "Unable to create a response from request. Response Status Code 500, possibly Server error."
  • Deleting with URL

    • Result: Failed
    • Issue: Unclear what is meant by URL in the command syntax (mesheryctl pattern delete {URL to patternfile}).

mesheryctl pattern offboard

  • URL-based pattern deletion

    • Result: Not implemented
    • Issue: Lack of URL-based pattern deletion in the implementation.
  • Redundancy with delete sub-command

    • Issue: There is no significant difference between the offboard and delete sub-commands, suggesting the offboard sub-command could be removed.

mesheryctl pattern view

  • Viewing patterns
    • Result: Successful
    • Issue: Sometimes the response is too large to be fully viewed in the CLI.

mesheryctl pattern list

  • Listing patterns
    • Result: Successful
    • Issue: None

@leecalcote
Copy link
Member

@singh1203, good progress. Send word when the tests are passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mesheryctl CLI for Meshery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mesheryctl] Remove onboard command from mesheryctl pattern commands
2 participants