Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil pointer dereference #10932

Merged
merged 2 commits into from
May 21, 2024

Conversation

code-sleuth
Copy link
Contributor

@code-sleuth code-sleuth commented May 13, 2024

Notes for Reviewers
Fix nil pointer dereference in return error message when no enities are found by the s.registry.GetEntities function in the Workload founction.

This PR is part of the fixes to:

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Ibrahim Mbaziira <code.ibra@gmail.com>
Copy link

github-actions bot commented May 13, 2024

@leecalcote leecalcote requested a review from alphaX86 May 13, 2024 20:16
@leecalcote
Copy link
Member

Are these test failures restricted to mesheryctl? https://github.com/meshery/meshery/actions/runs/9066486233/job/24909541975?pr=10932

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@code-sleuth
Copy link
Contributor Author

Are these test failures restricted to mesheryctl? https://github.com/meshery/meshery/actions/runs/9066486233/job/24909541975?pr=10932

@leecalcote yes they are

@leecalcote leecalcote merged commit dfbefd7 into meshery:master May 21, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants