Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI]: rtk-query migration for Extensions page #10948

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dottharun
Copy link
Contributor

@dottharun dottharun commented May 14, 2024

This PR is related to #9985

  • Library docs can be found here

Activity

  • Moved props for Adapters to connect at Extensions.
  • Provided rtk-query store for Extensions components.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

- and provide rtk-query store for Extensions

Signed-off-by: Tharun T <tharun242424@gmail.com>
@github-actions github-actions bot added the component/ui User Interface label May 14, 2024
Copy link

@dottharun dottharun changed the title [UI]: rtk-query migration for Extensions page [UI]: rtk-query migration for Extensions page May 14, 2024
@vishalvivekm
Copy link
Member

Hey @dottharun , let's discuss this on today's Meshery Dev meeting at 7:30 PM IST. I am adding this as an agenda item. Please Join https://meet.layer5.io/meshery if you are available during the meet.

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still in progress?

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what rtk query changes you are doing here? i am not seeing any change related to that

@dottharun
Copy link
Contributor Author

what rtk query changes you are doing here? i am not seeing any change related to that

Yes, currently only providing the rtk-query store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants