Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize hardware documentation #945

Merged
merged 13 commits into from Jan 28, 2024

Conversation

tekstrand
Copy link
Contributor

@tekstrand tekstrand commented Jan 25, 2024

What

  1. Update headings to follow semantic guidelines
  2. Shorten some tab names (t-beam)
  3. Add missing headings under tabs for semantics
  4. Remove extra duplicate words from headings when parent heading already contains context
  5. Standardize purchase link formatting for all RAK devices

Why

  1. Semantic html is easier to read, better for accessibility, and better for SEO
  2. There were enough tab names and the names were long enough that they were starting to wrap

Screenshots

Screenshot 2024-01-26 at 1 06 16 PM Screenshot 2024-01-26 at 1 06 10 PM Screenshot 2024-01-26 at 1 06 06 PM Screenshot 2024-01-26 at 1 06 02 PM Screenshot 2024-01-26 at 1 05 59 PM

Copy link

vercel bot commented Jan 25, 2024

@tekstrand is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2024

CLA assistant check
All committers have signed the CLA.

@pdxlocations
Copy link
Member

@tekstrand These edits look great! Would you mind signing the CLA?

Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meshtastic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2024 7:18pm

@rcarteraz
Copy link
Contributor

rcarteraz commented Jan 26, 2024

4. Remove extra duplicate words from headings when parent heading already contains context

The reason for this is because otherwise the headings in the navigation sidebar are all the same. It hasn’t been done universally, even though I planned to.

This differentiates them. Examples with and without.
(sorry for mobile but it’s the same on desktop just on the right instead).

IMG_1346
IMG_1347

@tekstrand
Copy link
Contributor Author

Ah that is a real bummer. A result of using tabs unfortunately. Definitely do not merge this as is - we need to either add them back and standardize that or create a fix for the tabs.

@rcarteraz
Copy link
Contributor

Ah that is a real bummer. A result of using tabs unfortunately. Definitely do not merge this as is - we need to either add them back and standardize that or create a fix for the tabs.

Yes, the tabs unfortunately cause a couple issues like this but that’s the option we have right now unless we add a page for every device and that’s too much imo.

However, we are currently exploring alternatives to Docusarus for reasons like this. See: https://discord.com/channels/867578229534359593/871540428510474302/1193046126031544472

there’s a thread with the discussion.

@tekstrand
Copy link
Contributor Author

tekstrand commented Jan 26, 2024

@rcarteraz
Copy link
Contributor

@rcarteraz thoughts on this solution? https://docusaurus.io/docs/api/themes/configuration#table-of-contents

Screenshot 2024-01-25 at 6 48 25 PM Screenshot 2024-01-25 at 6 50 35 PM

Amazing!… And now I feel pretty stupid for missing that. Thank you!

@tekstrand
Copy link
Contributor Author

Realized that the default config worked so reverted back, however did convert the indentation in that file over to spaces. If I need to remove that commit just lmk.

Copy link
Member

@pdxlocations pdxlocations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the new look of the TOC! The links never actually worked unless you're in the tab already so that's still a bummer.

docs/hardware/devices/heltec/index.mdx Show resolved Hide resolved
docs/hardware/devices/heltec/index.mdx Outdated Show resolved Hide resolved
docs/hardware/devices/lora/index.mdx Outdated Show resolved Hide resolved
docs/hardware/devices/nano/index.mdx Outdated Show resolved Hide resolved
docs/hardware/devices/rak/base-boards.mdx Outdated Show resolved Hide resolved
docs/hardware/devices/rak/base-boards.mdx Outdated Show resolved Hide resolved
docs/hardware/devices/rak/base-boards.mdx Outdated Show resolved Hide resolved
docs/hardware/devices/tbeam/index.mdx Outdated Show resolved Hide resolved
docs/hardware/devices/tbeam/index.mdx Outdated Show resolved Hide resolved
@tekstrand
Copy link
Contributor Author

♻️ updated with feedback

Tabs/TOC is an interesting topic. There's an issue that was closed by the maintainer of docusaurus requesting the feature. Amazed at the attitude that guy is responding with but that is beside the point.

I know we are considering a move to a different docs platform. I am not sure how many users we have that are visually impaired or using screen reading devices, but we should be sure consider those users as we choose a new platform and make UX decisions around doc structure.

@rcarteraz
Copy link
Contributor

♻️ updated with feedback

Tabs/TOC is an interesting topic. There's an issue that was closed by the maintainer of docusaurus requesting the feature. Amazed at the attitude that guy is responding with but that is beside the point.

I know we are considering a move to a different docs platform. I am not sure how many users we have that are visually impaired or using screen reading devices, but we should be sure consider those users as we choose a new platform and make UX decisions around doc structure.

Yeah, slorber. Quite the douchebag if I’m being honest.

@pdxlocations
Copy link
Member

I know we are considering a move to a different docs platform. I am not sure how many users we have that are visually impaired or using screen reading devices, but we should be sure consider those users as we choose a new platform and make UX decisions around doc structure.

I second this.

@tekstrand
Copy link
Contributor Author

♻️ purchase links standardized across all RAK pages. Will follow up with PRs for other devices but starting with RAK here.

@tekstrand
Copy link
Contributor Author

We'll call you hawkeye from now on! 😂
hawkeye

@pdxlocations
Copy link
Member

I think this is ready to ship, unless @rcarteraz has any suggestions?

@tekstrand
Copy link
Contributor Author

Sounds good, I'll start working on the other sections once this is merged.

@pdxlocations pdxlocations merged commit a58aa6a into meshtastic:master Jan 28, 2024
1 of 3 checks passed
@tekstrand tekstrand deleted the hardware-unification branch February 1, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants