New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize hardware documentation #945
Standardize hardware documentation #945
Conversation
@tekstrand is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
@tekstrand These edits look great! Would you mind signing the CLA? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The reason for this is because otherwise the headings in the navigation sidebar are all the same. It hasn’t been done universally, even though I planned to. This differentiates them. Examples with and without. |
Ah that is a real bummer. A result of using tabs unfortunately. Definitely do not merge this as is - we need to either add them back and standardize that or create a fix for the tabs. |
Yes, the tabs unfortunately cause a couple issues like this but that’s the option we have right now unless we add a page for every device and that’s too much imo. However, we are currently exploring alternatives to Docusarus for reasons like this. See: https://discord.com/channels/867578229534359593/871540428510474302/1193046126031544472 there’s a thread with the discussion. |
@rcarteraz thoughts on this solution? https://docusaurus.io/docs/api/themes/configuration#table-of-contents |
Amazing!… And now I feel pretty stupid for missing that. Thank you! |
dba48eb
to
58fa592
Compare
Realized that the default config worked so reverted back, however did convert the indentation in that file over to spaces. If I need to remove that commit just lmk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the new look of the TOC! The links never actually worked unless you're in the tab already so that's still a bummer.
♻️ updated with feedback Tabs/TOC is an interesting topic. There's an issue that was closed by the maintainer of docusaurus requesting the feature. Amazed at the attitude that guy is responding with but that is beside the point. I know we are considering a move to a different docs platform. I am not sure how many users we have that are visually impaired or using screen reading devices, but we should be sure consider those users as we choose a new platform and make UX decisions around doc structure. |
Yeah, slorber. Quite the douchebag if I’m being honest. |
I second this. |
♻️ purchase links standardized across all RAK pages. Will follow up with PRs for other devices but starting with RAK here. |
I think this is ready to ship, unless @rcarteraz has any suggestions? |
Sounds good, I'll start working on the other sections once this is merged. |
What
Why
Screenshots