Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade http library to 1.0, including some dependcies and hyper #22

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

themasch
Copy link

@themasch themasch commented Jan 4, 2024

While testing to get dav-server-rs working with a recent axum release, I encountered some problems because axum is using http@1.0, while dav-server-rs was still based on http@0.2.3.

Since the 1.0 release of http brings some stability & BC promises, I figured it might be work updating to the new release to this library is ready to be used with recent releases of all the frameworks building on http.

I did not touch the warp and actix example yet, that would be the next step.

I fixed up the hyper examples (the latest hyper release dropped some QoL features which bloats the example a bit) and ran the litmus test suite. Results where as documented in the README.

@themasch
Copy link
Author

themasch commented Jan 6, 2024

Okay, seems like neither warp nor actix currently support http 1.0 so I am not really sure how to fix those examples without depending on two versions of http, hyper, and some other things.

@ArcticLampyrid
Copy link

ArcticLampyrid commented Jan 12, 2024

Take miquels/webdav-handler-rs#33 as an example if you are interesting.
I've just found that there is a fork of miquels/webdav-handler-rs.

without depending on two versions of http, hyper, and some other things.

I don't think it's possible. http v0.4 must be used for warp / actix internally.

@themasch
Copy link
Author

@ArcticLampyrid to be honest, I'd be in favour of dropping the examples of warp/actix until they updated to http v1.0 over adding shim code to bridge between 1.0 and 0.4. But luckily thats not my call to make ;)

Having two somewhat actively maintained forks of whats effectively the same librarys makes things even more complicated. Looking at the history of both forks, the seem to diverge after 8972c98, in May 2021 (v 0.2.0).

I will have another (longer) look at your PR over the weekend and see if I can adapt that to this PR. Thank you for that!

@linuxtim
Copy link

seems like neither warp nor actix currently support http 1.0

To aide tracking these dependencies...

Warp issue to upgrade (via use of hyper 1.0) is here I think:

seanmonstar/warp#1088

Actix issue is here:

actix/actix-web#3208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants