upgrade deps with vulnerabilities #19128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19128 +/- ##
=======================================
Coverage 64.90% 64.90%
=======================================
Files 1866 1866
Lines 70677 70677
Branches 7762 7762
=======================================
Hits 45872 45872
Misses 21384 21384
Partials 3421 3421
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Can you rebase to the latest master? That shall fix the CI timeout issue on some of the checks. |
ariya
approved these changes
Nov 30, 2021
alxnddr
force-pushed
the
upgrade-deps
branch
from
3e89ed4
to
8fdc4f0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got a couple of deps with critical vulnerabilities. Fortunately, these dependencies come from building tools and documentation, which does not threaten the application itself. However, I added resolutions to secure packages for now. Once this PR facebook/create-react-app#11624 gets merged we will be able to remove these package resolutions.