-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Cypress event listener for beforeunload
globally
#38264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemanjaglumac
added
Type:Tech Debt
or Refactoring
.CI & Tests
backport
Automatically create PR on current release branch on merge
labels
Jan 30, 2024
kamilmielnik
approved these changes
Jan 30, 2024
|
@nemanjaglumac Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
metabase-bot bot
added a commit
that referenced
this pull request
Jan 30, 2024
cypress-io/cypress#2118 Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
npfitz
pushed a commit
that referenced
this pull request
Feb 5, 2024
sloansparger
pushed a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Automatically create PR on current release branch on merge
.CI & Tests
.Team/QueryingComponents
Type:Tech Debt
or Refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kamilmielnik added this workaround a while ago to the
pivot_tables.cy.spec.js
spec. But we saw other specs hanging and eventually timing out. Let's move this patch to the global Cypress file so it gets applied all specs.Please see this upstream issue:
cypress-io/cypress#2118