Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cypress event listener for beforeunload globally #38264

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

nemanjaglumac
Copy link
Member

@kamilmielnik added this workaround a while ago to the pivot_tables.cy.spec.js spec. But we saw other specs hanging and eventually timing out. Let's move this patch to the global Cypress file so it gets applied all specs.

Please see this upstream issue:
cypress-io/cypress#2118

@nemanjaglumac nemanjaglumac added Type:Tech Debt or Refactoring .CI & Tests backport Automatically create PR on current release branch on merge labels Jan 30, 2024
@nemanjaglumac nemanjaglumac requested review from kamilmielnik and a team January 30, 2024 13:57
@nemanjaglumac nemanjaglumac self-assigned this Jan 30, 2024
@kamilmielnik kamilmielnik requested a review from a team January 30, 2024 14:01
Copy link

replay-io bot commented Jan 30, 2024

StatusComplete ↗︎
Commitf6bf51d
Results
⚠️ 1 Flaky
2251 Passed

@nemanjaglumac nemanjaglumac merged commit 0c0e84c into master Jan 30, 2024
121 of 124 checks passed
@nemanjaglumac nemanjaglumac deleted the cypress-beforeunload branch January 30, 2024 14:32
Copy link

@nemanjaglumac Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .CI & Tests .Team/QueryingComponents Type:Tech Debt or Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants