Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node to 20.11.1 #39199

Closed
wants to merge 3 commits into from
Closed

Upgrade node to 20.11.1 #39199

wants to merge 3 commits into from

Conversation

uladzimirdev
Copy link
Contributor

Important

If you are merging into master, please add either a backport or a no-backport label to this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this PR? in the Metabase Branching Strategy document for more details.

Warning

If that is your first contribution to Metabase, please sign the Contributor License Agreement (unless it's a tiny documentation change). Also, if you're attempting to fix a translation issue, please submit your changes to our POEditor project instead of opening a PR.

Closes https://github.com/metabase/metabase/issues/[issue_number]

Description

Describe the overall approach and the problem being solved.

How to verify

Describe the steps to verify that the changes are working as expected.

  1. New question -> Sample Dataset -> ...
  2. ...

Demo

Upload a demo video or before/after screenshots if sensible or remove the section

Checklist

  • Tests have been added/updated to cover changes in this PR

@paoliniluis paoliniluis added the no-backport Do not backport this PR to any branch label Mar 13, 2024
@paoliniluis
Copy link
Contributor

This seems to pass all tests so 👍🏻

@metabase-bot metabase-bot bot added the visual Run Percy visual testing label Mar 27, 2024
Copy link

Codenotify: Notifying subscribers in CODENOTIFY files for diff 5d33359...4561e61.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/components/settings/ChartSettingLinkUrlInput.unit.spec.tsx

@uladzimirdev
Copy link
Contributor Author

The reason to close it - we still rely on node 18 and the actual fix I wanted to use from the node 20 was backported to 18 in nodejs/node#51004

@uladzimirdev uladzimirdev deleted the try-node-20 branch March 27, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents visual Run Percy visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants