Upgrade node to 18.20 #40661
Merged
Upgrade node to 18.20 #40661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff cc1f9f0...5b94085.
|
This reverts commit 8f4b39e.
uladzimirdev
commented
Mar 27, 2024
| @@ -80,7 +80,7 @@ describe("ChartSettingLinkUrlInput", () => { | |||
| const options = await getOptions(); | |||
|
|
|||
| userEvent.click(options[1]); | |||
| input.blur(); | |||
| userEvent.tab(); | |||
There was a problem hiding this comment.
will be reverted before merge. I used it only for triggering unit tests
There was a problem hiding this comment.
@uladzimirdev Should we add .nvmrc to frontend_sources?
WiNloSt
approved these changes
Mar 27, 2024
|
paoliniluis
added
the
backport
|
@uladzimirdev Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Upgrade node to 18.20 * Trigger CI * Try 20 again * Revert "Try 20 again" This reverts commit 8f4b39e. * Revert change * Add nvmrc to the frontend_sources list
oisincoveney
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Upgrade node to 18.20 * Trigger CI * Try 20 again * Revert "Try 20 again" This reverts commit 8f4b39e. * Revert change * Add nvmrc to the frontend_sources list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The node.js fix that affects jest performance was backported to 18.20, so we want to upgrade and get benefits from the tests speed
nodejs/node#51004
The fix is important as after node 16.* some regression related to reading and keeping files in memory was introduced in the node core and every next version of node made jest performance worse.
Related jest issue jestjs/jest#11956
Local test results running
yarn jest --maxWorkers=4 --silentAs per CI time - it can vary, but we can check trunk stats after 1–2 weeks