Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix malli error in defendpoint #42089

Merged
merged 3 commits into from
May 9, 2024
Merged

fix malli error in defendpoint #42089

merged 3 commits into from
May 9, 2024

Conversation

qnkhuat
Copy link
Contributor

@qnkhuat qnkhuat commented May 1, 2024 •
edited

@qnkhuat qnkhuat requested a review from camsaul as a code owner May 1, 2024 04:01
@metabase-bot metabase-bot bot added the .Team/BackendComponents also known as BEC label May 1, 2024
@qnkhuat qnkhuat added the no-backport Do not backport this PR to any branch label May 1, 2024
@qnkhuat qnkhuat requested a review from escherize May 1, 2024 04:05
escherize
escherize approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@escherize escherize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @qnkhuat. 👍

@replay-io replay.io
Copy link

replay-io bot commented May 9, 2024 •
edited

Status Complete ↗︎
Commit 1bab568
Results
⚠️ 10 Flaky
✅ 2470 Passed

@escherize escherize enabled auto-merge (squash) May 9, 2024 04:37
@escherize escherize merged commit 11594d8 into master May 9, 2024
111 checks passed
@escherize escherize deleted the fix-malli-error-defendpoint branch May 9, 2024 05:10
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

@qnkhuat Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@qnkhuat
Copy link
Contributor Author

qnkhuat commented May 9, 2024

Thanks @escherize !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escherize escherize escherize approved these changes

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

Assignees

@qnkhuat qnkhuat

Labels
no-backport Do not backport this PR to any branch .Team/BackendComponents also known as BEC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qnkhuat @escherize